Servlet not writing file

Question

I am uploading an image from c:\illuxplain on an android device. I have successfully uploaded the image but when I open it, it does not display.

Image size is non-zero in storage space and it displays extension .png. Why isn't the picture displaying? Is this right way to write file to storage space?

This is my servlet code

for (Part part : request.getParts()) {
    String fileName = extractFileName(part);
    File file = new File(fileSaveDir, fileName);
    InputStream input = part.getInputStream();

    byte[] buffer = new byte[1024];
    int len = input.read();

    FileOutputStream out = new FileOutputStream(file);
    while (len!=-1) {
        out.write(buffer,0,len);
        len = input.read(buffer);
    }
    out.close();
    input.close();
}

Refer to http://stackoverflow.com/questions/5882005/how-to-download-image-from-any-web-page-in-java — Ravindra babu, Aug 20 '15 at 16:16

score 2 · Accepted Answer · answered Aug 20 '15 at 16:35

2

You are using the wrong read method in the following line:

int len = input.read();

This should be:

int len = input.read(buffer);

answered Aug 20 '15 at 16:35

Andreas Veithen

8,868
3
25
28

Thank you very much. I really appreciate :) – mubeen Aug 20 '15 at 16:42
Is it is good way to write to storage space? (Code I have post) – mubeen Aug 20 '15 at 16:43
1

Usually one writes the loop as shown in sunrise76's answer. – Andreas Veithen Aug 20 '15 at 18:34

score 1 · Answer 2 · answered Aug 20 '15 at 16:37

1

Sample code:

byte data[] = new byte[1024];
long total = 0;
int count;


while ((count = input.read(data)) != -1) {
         total += count;
         output.write(data, 0, count);
}

output.flush();
output.close();

answered Aug 20 '15 at 16:37

Ravindra babu

37,698
11
250
211

Also consider making your `data` buffer much bigger - at least 10k. – Steve C Aug 21 '15 at 07:42

Servlet not writing file

2 Answers2