Java Login Program

Question

I wrote a very basic login program in Java recently and I'm doing everything right, but I always get that the username doesn't match.

Here is the program:

public static void main(String[] args) {

        //Creation
        String username = JOptionPane.showInputDialog(null, "Create Username:");
        int password = Integer.parseInt(JOptionPane.showInputDialog(null, "Create Password:\nOBS! Password Must Be Numbers!"));

        JOptionPane.showMessageDialog(null, "Success! Login Created!\nTransferring you to login screen...");

        //Login
        String loginu = JOptionPane.showInputDialog(null, "Username:");
        int loginp = Integer.parseInt(JOptionPane.showInputDialog(null, "Password:"));

        if (username == loginu && password == loginp) {

            JOptionPane.showMessageDialog(null, "Success!");

        }else if (username == loginu && password != loginp) {

            JOptionPane.showMessageDialog(null, "Password doesn't match.");

        }else if (username != loginu && password == loginp) {
            //always end up here!?
            JOptionPane.showMessageDialog(null, "Username doesn't match.");

        }else {

            JOptionPane.showMessageDialog(null, "Something went wrong.");

        }   

    }

}

possible duplicate of [How do I compare strings in Java?](http://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java) — piet.t, Jul 09 '15 at 09:04

score 1 · Answer 1 · edited May 23 '17 at 12:15

You should use .equals when comparing strings as they are not primitives but objects. Please see the below code . Refer to this for detailed answer

import javax.swing.JOptionPane;

public class fsdfd {

    public static void main(String[] args) {

        // Creation
        String username = JOptionPane.showInputDialog(null, "Create Username:");
        int password = Integer.parseInt(JOptionPane.showInputDialog(null,
                "Create Password:\nOBS! Password Must Be Numbers!"));

        JOptionPane.showMessageDialog(null,
                "Success! Login Created!\nTransferring you to login screen...");

        // Login
        String loginu = JOptionPane.showInputDialog(null, "Username:");
        int loginp = Integer.parseInt(JOptionPane.showInputDialog(null,
                "Password:"));

        if (username.equals(loginu) && password == loginp) {

            JOptionPane.showMessageDialog(null, "Success!");

        } else if (username.equals(loginu) && password != loginp) {

            JOptionPane.showMessageDialog(null, "Password doesn't match.");

        } else if (!username.equals(loginu) && password == loginp) {
            // You wont end up now
            JOptionPane.showMessageDialog(null, "Username doesn't match.");

        } else {

            JOptionPane.showMessageDialog(null, "Something went wrong.");

        }

    }

}

Well now i end up in "something went wrong"... should i delete it? — tTim, Jul 09 '15 at 09:46

score 0 · Answer 2 · answered Jul 09 '15 at 09:03

0

Use String equals method for comparison instead of ==.

username.equals(loginu) && password.equals(loginp)

answered Jul 09 '15 at 09:03

Rajesh

2,135
1
12
14

Java Login Program

2 Answers2